remove Wordpress check - #1
Open
roerch wants to merge 1 commit into
Open
Conversation
comment code which checks, whether Wordpress URL is below the Daiquiri URL since this is not necessarily the case for docker setups
Member
|
If the WordPress URL is not below the Daiquiri URL, Daiquiri cannot delete the WordPress login cookie, therefore a Daiquiri Logout would not trigger a WordPress Logout which would be a Problem. This is the code in Daiquiri which handles the WP Logout: https://github.com/django-daiquiri/daiquiri/blob/master/daiquiri/auth/views.py#L70 |
Author
|
Actually it does work, since in the docker setup, the WordPress cookies are stored with "/" as path. (Sorry, I don't find the code fragment for this right now) |
Member
|
Ok, but then we need to check the domain otherwise we could have faulty setups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comment code which checks, whether Wordpress URL is below the Daiquiri URL
since this is not necessarily the case for docker setups
Should be checked whether this leads to problems in old setups before merging